fix(interpreter): set -e respects AND-OR lists in functions and loops#824
Merged
fix(interpreter): set -e respects AND-OR lists in functions and loops#824
Conversation
Closes #807 — `set -e` no longer incorrectly exits when `[[ cond ]] && cmd` has a false condition inside functions, brace groups, or for/while/until loops. Root cause: execute_command_sequence_impl and loop bodies had redundant errexit checks that didn't account for AND-OR list context. Fix: 1. Skip errexit in sequence executor for Command::List with && or || operators 2. Remove redundant errexit checks in for/while/until loop bodies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -eincorrectly exiting on[[ cond ]] && cmdinside functions, brace groups, and loopsexecute_command_sequence_implforCommand::Listwith&&/||operatorsTest plan
set_e_and_list_in_function—[[ false ]] && return 0in functionset_e_and_list_in_brace_group—[[ false ]] && echoin{ } > fileset_e_and_list_in_for_loop—[[ false ]] && return 0in for loopset_e_and_list_top_level— top-level AND-OR still worksset_e_exits_on_plain_failure—falsestill exits under set -eCloses #807